Repository navigation
redis: support REDIS_POOL_ON_EMPTY_BEHAVIOR=ERROR - #1299
Merged
Merged
Conversation
Since the move to radix v4, REDIS_POOL_ON_EMPTY_BEHAVIOR=ERROR (and CREATE) panics at startup, leaving WAIT, an unbounded wait, as the only usable value, and the README still documented the radix v3 behavior. With a fixed-size radix v4 pool and pipelines sharing connections, a command only waits for a connection when the pool has none, i.e. when Redis is unreachable and the pool is re-dialing. That wait is now bounded by the request deadline (WAIT). ERROR is supported again and makes such commands fail right away. CREATE still refuses to start, since radix v4 cannot create overflow connections. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Ignasi Barrera <ignasi@tetrate.io>
nacx
force-pushed
the
pr/h-pool-on-empty-error
branch
from
November 9, 2026 15:02
25d898a to
34a4bd5
Compare
psbrar99
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the move to radix v4, REDIS_POOL_ON_EMPTY_BEHAVIOR=ERROR (and CREATE) panics at startup, leaving WAIT, an unbounded wait, as the only usable value, and the README still documented the radix v3 behavior.
With a fixed-size radix v4 pool and pipelines sharing connections, a command only waits for a connection when the pool has none, i.e. when Redis is unreachable and the pool is re-dialing. That wait is now bounded by the request deadline (WAIT). ERROR is supported again and makes such commands fail right away. CREATE still refuses to start, since radix v4 cannot create overflow connections.